[
https://issues.apache.org/jira/browse/HADOOP-18487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17616597#comment-17616597
]
ASF GitHub Bot commented on HADOOP-18487:
-----------------------------------------
steveloughran commented on PR #4996:
URL: https://github.com/apache/hadoop/pull/4996#issuecomment-1276497357
having just seen #2026 i'm not convinced we can remove protobuf2.5 off the
classpath of anything using the RPC classes. There's a lot of internal probing
for object types and dynamic choice of shaded/unshaded classes.
It might be possible to pull out the code from the shared classes (server,
rpcwritable...) so be confident that rpc clients only using the shaded
libraries and the RpcEngine2 were safely isolated, but right now I am not
convinced that is true. Certainly hdfs, mr and yarn servers and clients MUST
export protobuf2, even if hadoop-common downgrades it.
> protobuf-2.5.0 dependencies => provided
> ---------------------------------------
>
> Key: HADOOP-18487
> URL: https://issues.apache.org/jira/browse/HADOOP-18487
> Project: Hadoop Common
> Issue Type: Improvement
> Components: build, ipc
> Affects Versions: 3.3.4
> Reporter: Steve Loughran
> Priority: Major
> Labels: pull-request-available
>
> uses of protobuf 2.5 and RpcEnginej have been deprecated since 3.3.0 in
> HADOOP-17046
> while still keeping those files around (for a long time...), how about we
> make the protobuf 2.5.0 export off hadoop common and hadoop-hdfs *provided*,
> rather than *compile*
> that way, if apps want it for their own apis, they have to explicitly ask for
> it, but at least our own scans don't break.
> i have no idea what will happen to the rest of the stack at this point, it
> will be "interesting" to see
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
