[
https://issues.apache.org/jira/browse/HADOOP-18487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17616930#comment-17616930
]
ASF GitHub Bot commented on HADOOP-18487:
-----------------------------------------
steveloughran commented on PR #4996:
URL: https://github.com/apache/hadoop/pull/4996#issuecomment-1277387176
we can't cut an unshaded protobuf of some form without RPC not linking, so
hbase/hive/ozone are in trouble here. changes to RPC.java required to somehow
add ability to probe a class for being a subclass of
com.google.protobuf.Message without having com.google.protobuf.Message on the
classpath would be needed.
*this does not need to be protobuf 2.5*.
I propose
1. changing some of the imports of hadoop-common to exclude it (cloud
components)
2. changing retention here back to `compile`
that way someone can turn it off if they want to, but it is not something we
do in normal asf releases.
> protobuf-2.5.0 dependencies => provided
> ---------------------------------------
>
> Key: HADOOP-18487
> URL: https://issues.apache.org/jira/browse/HADOOP-18487
> Project: Hadoop Common
> Issue Type: Improvement
> Components: build, ipc
> Affects Versions: 3.3.4
> Reporter: Steve Loughran
> Priority: Major
> Labels: pull-request-available
>
> uses of protobuf 2.5 and RpcEnginej have been deprecated since 3.3.0 in
> HADOOP-17046
> while still keeping those files around (for a long time...), how about we
> make the protobuf 2.5.0 export off hadoop common and hadoop-hdfs *provided*,
> rather than *compile*
> that way, if apps want it for their own apis, they have to explicitly ask for
> it, but at least our own scans don't break.
> i have no idea what will happen to the rest of the stack at this point, it
> will be "interesting" to see
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
