slfan1989 commented on code in PR #4982:
URL: https://github.com/apache/hadoop/pull/4982#discussion_r995247359
##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/conf/YarnConfiguration.java:
##########
@@ -4128,11 +4128,87 @@ public static boolean isAclEnabled(Configuration conf) {
public static final String ROUTER_WEBAPP_PREFIX = ROUTER_PREFIX + "webapp.";
+ /**
+ * This configurable that controls the thread pool size of the threadpool of
the interceptor.
+ * The corePoolSize(minimumPoolSize) and maximumPoolSize of the thread pool
+ * are controlled by this configurable.
+ * In order to control the thread pool more accurately, this parameter is
deprecated.
+ *
+ * corePoolSize(minimumPoolSize) use
+ * {@link YarnConfiguration#ROUTER_USER_CLIENT_THREAD_POOL_MINIMUM_POOL_SIZE}
+ *
+ * maximumPoolSize use
+ * {@link YarnConfiguration#ROUTER_USER_CLIENT_THREAD_POOL_MAXIMUM_POOL_SIZE}
+ *
+ * This configurable will be deprecated.
+ */
public static final String ROUTER_USER_CLIENT_THREADS_SIZE =
ROUTER_PREFIX + "interceptor.user.threadpool-size";
+ /**
+ * The default value is 5.
+ * which means that the corePoolSize(minimumPoolSize) and maximumPoolSize
+ * of the thread pool are both 5s.
+ *
+ * corePoolSize(minimumPoolSize) default value use
+ * {@link
YarnConfiguration#DEFAULT_ROUTER_USER_CLIENT_THREAD_POOL_MINIMUM_POOL_SIZE}
+ *
+ * maximumPoolSize default value use
+ * {@link
YarnConfiguration#DEFAULT_ROUTER_USER_CLIENT_THREAD_POOL_MAXIMUM_POOL_SIZE}
+ */
public static final int DEFAULT_ROUTER_USER_CLIENT_THREADS_SIZE = 5;
+ /**
+ * This configurable is used to set the corePoolSize(minimumPoolSize)
+ * of the thread pool of the interceptor.
+ *
+ * corePoolSize the number of threads to keep in the pool, even if they are
idle.
+ */
+ public static final String ROUTER_USER_CLIENT_THREAD_POOL_MINIMUM_POOL_SIZE =
+ ROUTER_PREFIX + "interceptor.user-thread-pool.minimum-pool-size";
+
+ /**
+ * This configuration is used to set the default value of corePoolSize
(minimumPoolSize)
+ * of the thread pool of the interceptor.
+ *
+ * Default is 5.
+ */
+ public static final int
DEFAULT_ROUTER_USER_CLIENT_THREAD_POOL_MINIMUM_POOL_SIZE = 5;
+
+ /**
+ * This configurable is used to set the maximumPoolSize of the thread pool
of the interceptor.
+ *
+ * maximumPoolSize the maximum number of threads to allow in the pool.
+ */
+ public static final String ROUTER_USER_CLIENT_THREAD_POOL_MAXIMUM_POOL_SIZE =
+ ROUTER_PREFIX + "interceptor.user-thread-pool.maximum-pool-size";
+
+ /**
+ * This configuration is used to set the default value of maximumPoolSize
+ * of the thread pool of the interceptor.
+ *
+ * Default is 5.
+ */
+ public static final int
DEFAULT_ROUTER_USER_CLIENT_THREAD_POOL_MAXIMUM_POOL_SIZE = 5;
+
+ /**
+ * This configurable is used to set the keepAliveTime of the thread pool of
the interceptor.
+ *
+ * keepAliveTime when the number of threads is greater than the core,
+ * this is the maximum time that excess idle threads will wait for new tasks
before terminating.
+ */
+ public static final String ROUTER_USER_CLIENT_THREAD_POOL_KEEP_ALIVE_TIME =
+ ROUTER_PREFIX + "interceptor.user-thread-pool.keep-alive-time";
+
+ /**
+ * This configurable is used to set the default time of keepAliveTime
+ * of the thread pool of the interceptor.
+ *
+ * the default value is 10s.
+ */
+ public static final long
DEFAULT_ROUTER_USER_CLIENT_THREAD_POOL_KEEP_ALIVE_TIME =
Review Comment:
Thanks for your suggestion, I will modify the code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
