slfan1989 commented on code in PR #4982:
URL: https://github.com/apache/hadoop/pull/4982#discussion_r1005236005
##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router/src/main/java/org/apache/hadoop/yarn/server/router/clientrm/FederationClientInterceptor.java:
##########
@@ -1948,4 +1953,44 @@ private void
updateReservationHomeSubCluster(SubClusterId subClusterId,
}
}
}
+
+ protected int getNumMinThreads(Configuration conf) {
+
+ String threadSize =
conf.get(YarnConfiguration.ROUTER_USER_CLIENT_THREADS_SIZE);
+
+ // If the user configures
YarnConfiguration.ROUTER_USER_CLIENT_THREADS_SIZE,
+ // we will still get the number of threads from this configuration.
+ if (StringUtils.isNotBlank(threadSize)) {
+ LOG.warn("{} is an deprecated property, " +
+ "please remove it, use {} to configure the minimum number of thread
pool.",
+ YarnConfiguration.ROUTER_USER_CLIENT_THREADS_SIZE,
+ YarnConfiguration.ROUTER_USER_CLIENT_THREAD_POOL_MINIMUM_POOL_SIZE);
+ return Integer.parseInt(threadSize);
+ }
+
+ int numMinThreads = getConf().getInt(
Review Comment:
I'll fix it.
##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router/src/main/java/org/apache/hadoop/yarn/server/router/clientrm/FederationClientInterceptor.java:
##########
@@ -1948,4 +1953,44 @@ private void
updateReservationHomeSubCluster(SubClusterId subClusterId,
}
}
}
+
+ protected int getNumMinThreads(Configuration conf) {
+
+ String threadSize =
conf.get(YarnConfiguration.ROUTER_USER_CLIENT_THREADS_SIZE);
+
+ // If the user configures
YarnConfiguration.ROUTER_USER_CLIENT_THREADS_SIZE,
+ // we will still get the number of threads from this configuration.
+ if (StringUtils.isNotBlank(threadSize)) {
+ LOG.warn("{} is an deprecated property, " +
+ "please remove it, use {} to configure the minimum number of thread
pool.",
+ YarnConfiguration.ROUTER_USER_CLIENT_THREADS_SIZE,
+ YarnConfiguration.ROUTER_USER_CLIENT_THREAD_POOL_MINIMUM_POOL_SIZE);
+ return Integer.parseInt(threadSize);
+ }
+
+ int numMinThreads = getConf().getInt(
+ YarnConfiguration.ROUTER_USER_CLIENT_THREAD_POOL_MINIMUM_POOL_SIZE,
+
YarnConfiguration.DEFAULT_ROUTER_USER_CLIENT_THREAD_POOL_MINIMUM_POOL_SIZE);
+ return numMinThreads;
+ }
+
+ protected int getNumMaxThreads(Configuration conf) {
+
+ String threadSize =
conf.get(YarnConfiguration.ROUTER_USER_CLIENT_THREADS_SIZE);
+
+ // If the user configures
YarnConfiguration.ROUTER_USER_CLIENT_THREADS_SIZE,
+ // we will still get the number of threads from this configuration.
+ if (StringUtils.isNotBlank(threadSize)) {
+ LOG.warn("{} is an deprecated property, " +
Review Comment:
I'll fix it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
