haiyang1987 commented on code in PR #5063:
URL: https://github.com/apache/hadoop/pull/5063#discussion_r1002622697
##########
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/DatanodeAdminManager.java:
##########
@@ -108,32 +108,6 @@ void activate(Configuration conf) {
Preconditions.checkArgument(intervalSecs >= 0, "Cannot set a negative " +
"value for " + DFSConfigKeys.DFS_NAMENODE_DECOMMISSION_INTERVAL_KEY);
- int blocksPerInterval = conf.getInt(
- DFSConfigKeys.DFS_NAMENODE_DECOMMISSION_BLOCKS_PER_INTERVAL_KEY,
- DFSConfigKeys.DFS_NAMENODE_DECOMMISSION_BLOCKS_PER_INTERVAL_DEFAULT);
-
- final String deprecatedKey =
- "dfs.namenode.decommission.nodes.per.interval";
- final String strNodes = conf.get(deprecatedKey);
- if (strNodes != null) {
- LOG.warn("Deprecated configuration key {} will be ignored.",
- deprecatedKey);
- LOG.warn("Please update your configuration to use {} instead.",
- DFSConfigKeys.DFS_NAMENODE_DECOMMISSION_BLOCKS_PER_INTERVAL_KEY);
- }
Review Comment:
@ZanderXu thanks for your review
Yeah, but this logic may need to be moved to
DatanodeAdminDefaultMonitor#processConf,
Because this parameter is only meaningful for the
DatanodeAdminDefaultMonitor class
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
