[
https://issues.apache.org/jira/browse/HADOOP-17612?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17625843#comment-17625843
]
ASF GitHub Bot commented on HADOOP-17612:
-----------------------------------------
xinglin commented on code in PR #5067:
URL: https://github.com/apache/hadoop/pull/5067#discussion_r1008330919
##########
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/token/delegation/ZKDelegationTokenSecretManager.java:
##########
@@ -417,24 +408,18 @@ private void processTokenAddOrUpdate(byte[] data) throws
IOException {
if (numRead > -1) {
DelegationTokenInformation tokenInfo =
new DelegationTokenInformation(renewDate, password);
- synchronized (this) {
Review Comment:
This change removes a few synchronized keywords. I cross-check with trunk
and trunk also removes these. seems fine but I have no context on why
synchronized was used before and now removed.
##########
hadoop-hdfs-project/hadoop-hdfs-rbf/src/test/java/org/apache/hadoop/hdfs/server/federation/security/token/TestZKDelegationTokenSecretManagerImpl.java:
##########
@@ -101,6 +101,7 @@ public void testMultiNodeOperationWithoutWatch() throws
Exception {
}
}
+ @SuppressWarnings("unchecked")
Review Comment:
trunk does not suppress here. Maybe we shouldn't neither?
##########
hadoop-hdfs-project/hadoop-hdfs-rbf/src/test/java/org/apache/hadoop/hdfs/server/federation/security/token/TestZKDelegationTokenSecretManagerImpl.java:
##########
@@ -162,6 +162,7 @@ public void testMultiNodeTokenRemovalShortSyncWithoutWatch()
// This is very unlikely to happen in real case, but worth putting
// the case out
+ @SuppressWarnings("unchecked")
Review Comment:
trunk does not have suppress here.
> Upgrade Zookeeper to 3.6.3 and Curator to 5.2.0
> -----------------------------------------------
>
> Key: HADOOP-17612
> URL: https://issues.apache.org/jira/browse/HADOOP-17612
> Project: Hadoop Common
> Issue Type: Task
> Reporter: Viraj Jasani
> Assignee: Viraj Jasani
> Priority: Major
> Labels: pull-request-available
> Fix For: 3.4.0
>
> Time Spent: 4h
> Remaining Estimate: 0h
>
> Let's upgrade Zookeeper and Curator to 3.6.3 and 5.2.0 respectively.
> Curator 5.2 also supports Zookeeper 3.5 servers.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
