[
https://issues.apache.org/jira/browse/HADOOP-17612?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17625890#comment-17625890
]
ASF GitHub Bot commented on HADOOP-17612:
-----------------------------------------
melissayou commented on code in PR #5067:
URL: https://github.com/apache/hadoop/pull/5067#discussion_r1008446843
##########
hadoop-hdfs-project/hadoop-hdfs-rbf/src/test/java/org/apache/hadoop/hdfs/server/federation/security/token/TestZKDelegationTokenSecretManagerImpl.java:
##########
@@ -162,6 +162,7 @@ public void testMultiNodeTokenRemovalShortSyncWithoutWatch()
// This is very unlikely to happen in real case, but worth putting
// the case out
+ @SuppressWarnings("unchecked")
Review Comment:
Yes it was added by me to fix failed javac problem reported in earlier
[builds](https://github.com/apache/hadoop/pull/5067#issuecomment-1292262434).
There're two similar places(line135&201) and either will fail javac.
So two ways:
1. Keep it in sync with trunk and let javac fail for this PR.
2. (What I did here) fix it by adding suppress warning here as I'm pretty
confident those types are correct. This test file is inconsistent - you can see
the untouched method testMultiNodeOperationWithoutWatch() has the exact same
problem and has suppress warning. So I think it's applicable to the other two
methods as well.
> Upgrade Zookeeper to 3.6.3 and Curator to 5.2.0
> -----------------------------------------------
>
> Key: HADOOP-17612
> URL: https://issues.apache.org/jira/browse/HADOOP-17612
> Project: Hadoop Common
> Issue Type: Task
> Reporter: Viraj Jasani
> Assignee: Viraj Jasani
> Priority: Major
> Labels: pull-request-available
> Fix For: 3.4.0
>
> Time Spent: 4h
> Remaining Estimate: 0h
>
> Let's upgrade Zookeeper and Curator to 3.6.3 and 5.2.0 respectively.
> Curator 5.2 also supports Zookeeper 3.5 servers.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
