tomscut commented on code in PR #5068:
URL: https://github.com/apache/hadoop/pull/5068#discussion_r1008773687
##########
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNode.java:
##########
@@ -2601,6 +2611,36 @@ private String reconfigureBlockInvalidateLimit(final
DatanodeManager datanodeMan
}
}
+ private String reconfigureDecommissionBackoffMonitorParameters(
+ final DatanodeManager datanodeManager, final String property, final
String newVal)
+ throws ReconfigurationException {
+ String newSetting;
+ try {
+ if
(property.equals(DFS_NAMENODE_DECOMMISSION_BACKOFF_MONITOR_PENDING_LIMIT)) {
+ int pendingRepLimit = (newVal == null ?
+ DFS_NAMENODE_DECOMMISSION_BACKOFF_MONITOR_PENDING_LIMIT_DEFAULT :
+ Integer.parseInt(newVal));
+
datanodeManager.getDatanodeAdminManager().refreshPendingRepLimit(pendingRepLimit,
+ DFS_NAMENODE_DECOMMISSION_BACKOFF_MONITOR_PENDING_LIMIT);
+ newSetting =
String.valueOf(datanodeManager.getDatanodeAdminManager().getPendingRepLimit());
+ } else if
(property.equals(DFS_NAMENODE_DECOMMISSION_BACKOFF_MONITOR_PENDING_BLOCKS_PER_LOCK))
{
+ int blocksPerLock = (newVal == null ?
+
DFS_NAMENODE_DECOMMISSION_BACKOFF_MONITOR_PENDING_BLOCKS_PER_LOCK_DEFAULT :
+ Integer.parseInt(newVal));
+
datanodeManager.getDatanodeAdminManager().refreshBlocksPerLock(blocksPerLock,
+ DFS_NAMENODE_DECOMMISSION_BACKOFF_MONITOR_PENDING_BLOCKS_PER_LOCK);
+ newSetting =
String.valueOf(datanodeManager.getDatanodeAdminManager().getBlocksPerLock());
+ } else {
+ throw new IllegalArgumentException("Unexpected property " +
Review Comment:
Thanks @haiyang1987 for updating. This can be removed because the value of
the key is already judged in the outer layer.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
