tomscut commented on code in PR #5068:
URL: https://github.com/apache/hadoop/pull/5068#discussion_r1008775655
##########
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/DatanodeAdminManager.java:
##########
@@ -419,4 +419,28 @@ void runMonitorForTest() throws ExecutionException,
InterruptedException {
executor.submit(monitor).get();
}
+ public void refreshPendingRepLimit(int pendingRepLimit, String key) {
+ ensurePositiveInt(pendingRepLimit, key);
+ this.monitor.setPendingRepLimit(pendingRepLimit);
+ }
+
+ public int getPendingRepLimit() {
Review Comment:
Please add `@VisibleForTesting`.
##########
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/DatanodeAdminManager.java:
##########
@@ -419,4 +419,28 @@ void runMonitorForTest() throws ExecutionException,
InterruptedException {
executor.submit(monitor).get();
}
+ public void refreshPendingRepLimit(int pendingRepLimit, String key) {
+ ensurePositiveInt(pendingRepLimit, key);
+ this.monitor.setPendingRepLimit(pendingRepLimit);
+ }
+
+ public int getPendingRepLimit() {
+ return this.monitor.getPendingRepLimit();
+ }
+
+ public void refreshBlocksPerLock(int blocksPerLock, String key) {
+ ensurePositiveInt(blocksPerLock, key);
+ this.monitor.setBlocksPerLock(blocksPerLock);
+ }
+
+ public int getBlocksPerLock() {
Review Comment:
Add `@VisibleForTesting`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
