goiri commented on code in PR #5236:
URL: https://github.com/apache/hadoop/pull/5236#discussion_r1053591430
##########
hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/net/TestNetUtils.java:
##########
@@ -39,6 +39,7 @@
import java.util.concurrent.TimeUnit;
import org.apache.commons.lang3.StringUtils;
+import org.apache.ftpserver.command.impl.PORT;
Review Comment:
Why do we need this?
##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/webapp/util/WebAppUtils.java:
##########
@@ -428,6 +429,12 @@ public static String getAggregatedLogURL(String
serverHttpAddress,
user == null || user.isEmpty()) {
return null;
}
+ String[] ipAdds = serverHttpAddress.split("//");
+ if (ipAdds.length >= 2 && StringUtils.countMatches(ipAdds[1], ":") > 2) {
Review Comment:
I think this is pretty much NetUtils.isIPV6Address
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
