Daniel-009497 commented on code in PR #5236:
URL: https://github.com/apache/hadoop/pull/5236#discussion_r1055155907
##########
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/net/NetUtils.java:
##########
@@ -229,6 +230,23 @@ public static InetSocketAddress createSocketAddr(String
target,
}
target = target.trim();
boolean hasScheme = target.contains("://");
+ if (StringUtils.countMatches(target, ":") > 2) {
Review Comment:
Thanks for review, fixed as you mentioned
##########
hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/net/TestNetUtils.java:
##########
@@ -39,6 +39,7 @@
import java.util.concurrent.TimeUnit;
import org.apache.commons.lang3.StringUtils;
+import org.apache.ftpserver.command.impl.PORT;
Review Comment:
Thanks for review, fixed as you mentioned
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
