cnauroth commented on code in PR #5248:
URL: https://github.com/apache/hadoop/pull/5248#discussion_r1058507029
##########
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/UserGroupInformation.java:
##########
@@ -1287,14 +1314,18 @@ private void reloginFromKeytab(boolean checkTGT,
boolean ignoreLastLoginTime)
@InterfaceAudience.Public
@InterfaceStability.Evolving
public void reloginFromTicketCache() throws IOException {
- if (!shouldRelogin() || !isFromTicket()) {
+ reloginFromTicketCache(false);
+ }
+
+ private void reloginFromTicketCache(boolean ignoreLastLoginTime) throws
IOException {
+ if (!shouldRelogin() || !isFromTicket()) {
Review Comment:
There is a Checkstyle warning here about indentation:
```
./hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/UserGroupInformation.java:1321:
if (!shouldRelogin() || !isFromTicket()) {: 'if' has incorrect indentation
level 5, expected level should be 4. [Indentation]
```
##########
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/UserGroupInformation.java:
##########
@@ -529,6 +529,16 @@ private void setLogin(LoginContext login) {
user.setLogin(login);
}
+ /** This method checks for a successful Kerberos login
Review Comment:
This is generating a new JavaDoc warning:
```
[ERROR]
/home/jenkins/jenkins-home/workspace/hadoop-multibranch_PR-5248/ubuntu-focal/src/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/UserGroupInformation.java:535:
warning: no @return
[ERROR] public boolean isLoginSuccess() {
[ERROR] ^
```
Additionally, I suggest sticking to the existing style of line break right
after the opening and an asterisk on each line:
```
/**
* line 1
* line 2
*
* @return foo
*/
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
