liuml07 commented on PR #5248: URL: https://github.com/apache/hadoop/pull/5248#issuecomment-1370342353
It has been a while since last time I check the security code. My understanding fades away as security is complex and risky. Consider my comments non-binding here. It makes sense to have to force re-login for addressing the issue. 1. Is it possible to figure out some unit tests (not necessarily NN+JN case) for Server and/or UGI? Even the current code change is straightforward, it may be broken by mistake or misunderstanding in future. 2. Do we need `Server#canTryForceLogin` to be thread-safe for multiple connections? 3. Is it clear to extract the new code in `Server` to a private helper method? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
