[ https://issues.apache.org/jira/browse/HADOOP-18581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17652556#comment-17652556 ]
ASF GitHub Bot commented on HADOOP-18581: ----------------------------------------- cnauroth commented on code in PR #5248: URL: https://github.com/apache/hadoop/pull/5248#discussion_r1058507029 ########## hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/UserGroupInformation.java: ########## @@ -1287,14 +1314,18 @@ private void reloginFromKeytab(boolean checkTGT, boolean ignoreLastLoginTime) @InterfaceAudience.Public @InterfaceStability.Evolving public void reloginFromTicketCache() throws IOException { - if (!shouldRelogin() || !isFromTicket()) { + reloginFromTicketCache(false); + } + + private void reloginFromTicketCache(boolean ignoreLastLoginTime) throws IOException { + if (!shouldRelogin() || !isFromTicket()) { Review Comment: There is a Checkstyle warning here about indentation: ``` ./hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/UserGroupInformation.java:1321: if (!shouldRelogin() || !isFromTicket()) {: 'if' has incorrect indentation level 5, expected level should be 4. [Indentation] ``` ########## hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/UserGroupInformation.java: ########## @@ -529,6 +529,16 @@ private void setLogin(LoginContext login) { user.setLogin(login); } + /** This method checks for a successful Kerberos login Review Comment: This is generating a new JavaDoc warning: ``` [ERROR] /home/jenkins/jenkins-home/workspace/hadoop-multibranch_PR-5248/ubuntu-focal/src/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/UserGroupInformation.java:535: warning: no @return [ERROR] public boolean isLoginSuccess() { [ERROR] ^ ``` Additionally, I suggest sticking to the existing style of line break right after the opening and an asterisk on each line: ``` /** * line 1 * line 2 * * @return foo */ ``` > Handle Server KDC re-login when Server and Client run in same JVM. > ------------------------------------------------------------------ > > Key: HADOOP-18581 > URL: https://issues.apache.org/jira/browse/HADOOP-18581 > Project: Hadoop Common > Issue Type: Bug > Affects Versions: 3.1.1 > Reporter: Surendra Singh Lilhore > Assignee: Surendra Singh Lilhore > Priority: Major > Labels: pull-request-available > > Handle re-login in Server when client, server running in same JVM and client > trying to re-login, but it fails. > For example, NameNode is server but in same JVM journal node client also > running to push to edit logs. When JN client try to re-login and it fails, it > will destroy server service ticket also and NameNode not able to server > client request. We can see the below error logs in NameNode log file. > > {noformat} > Auth failed for x.x.x.x:42199:null (GSS initiate failed) with true cause: > (GSS initiate failed) > Auth failed for x.x.x.x:42199:null (GSS initiate failed) with true cause: > (GSS initiate failed) > Auth failed for x.x.x.x:42199:null (GSS initiate failed) with true cause: > (GSS initiate failed){noformat} > Same discussion happened in HADOOP-17996. -- This message was sent by Atlassian Jira (v8.20.10#820010) --------------------------------------------------------------------- To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org