[
https://issues.apache.org/jira/browse/HADOOP-18581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17654376#comment-17654376
]
ASF GitHub Bot commented on HADOOP-18581:
-----------------------------------------
surendralilhore commented on PR #5248:
URL: https://github.com/apache/hadoop/pull/5248#issuecomment-1370726197
Thanks @liuml07 for review.
> 1. Is it possible to figure out some unit tests (not necessarily NN+JN
case) for Server and/or UGI? Even the current code change is straightforward,
it may be broken by mistake or misunderstanding in future.
Adding UT for this scenario is difficult. Passing Sasl message to server
without any proper channel and making it fail is difficult.
> 2. Do we need `Server#canTryForceLogin` to be thread-safe for multiple
connections?
Changed `Server#canTryForceLogin` to `AtomicBoolean`
> 3. Is it clear to extract the new code in `Server` to a private helper
method?
Re-login logic extracted in new method and made it synchronized to avoid
multiple re-relogin in concurrent scenario.
> Handle Server KDC re-login when Server and Client run in same JVM.
> ------------------------------------------------------------------
>
> Key: HADOOP-18581
> URL: https://issues.apache.org/jira/browse/HADOOP-18581
> Project: Hadoop Common
> Issue Type: Bug
> Affects Versions: 3.1.1
> Reporter: Surendra Singh Lilhore
> Assignee: Surendra Singh Lilhore
> Priority: Major
> Labels: pull-request-available
>
> Handle re-login in Server when client, server running in same JVM and client
> trying to re-login, but it fails.
> For example, NameNode is server but in same JVM journal node client also
> running to push to edit logs. When JN client try to re-login and it fails, it
> will destroy server service ticket also and NameNode not able to server
> client request. We can see the below error logs in NameNode log file.
>
> {noformat}
> Auth failed for x.x.x.x:42199:null (GSS initiate failed) with true cause:
> (GSS initiate failed)
> Auth failed for x.x.x.x:42199:null (GSS initiate failed) with true cause:
> (GSS initiate failed)
> Auth failed for x.x.x.x:42199:null (GSS initiate failed) with true cause:
> (GSS initiate failed){noformat}
> Same discussion happened in HADOOP-17996.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
