mukund-thakur commented on code in PR #4499: URL: https://github.com/apache/hadoop/pull/4499#discussion_r1062124836
########## hadoop-tools/hadoop-aws/src/site/markdown/tools/hadoop-aws/delegation_tokens.md: ########## @@ -108,7 +108,7 @@ password-protected data opaque to clients; they contain the secrets needed to access the relevant S3 buckets and associated services. They are obtained by requesting a delegation token from the S3A filesystem client. Review Comment: Not sure why github not allowing me to comment at L82. Delegation "Token" support is ########## hadoop-tools/hadoop-aws/src/site/markdown/tools/hadoop-aws/delegation_tokens.md: ########## @@ -108,7 +108,7 @@ password-protected data opaque to clients; they contain the secrets needed to access the relevant S3 buckets and associated services. They are obtained by requesting a delegation token from the S3A filesystem client. Review Comment: l120 : It -> it. ########## hadoop-tools/hadoop-aws/src/site/markdown/tools/hadoop-aws/delegation_tokens.md: ########## @@ -108,7 +108,7 @@ password-protected data opaque to clients; they contain the secrets needed to access the relevant S3 buckets and associated services. They are obtained by requesting a delegation token from the S3A filesystem client. Review Comment: L106 -> These S3A Delegation Tokens are special in "a way" that ########## hadoop-tools/hadoop-aws/src/site/markdown/tools/hadoop-aws/delegation_tokens.md: ########## @@ -353,10 +352,10 @@ it is authenticated with; the role token binding will fail. When the AWS credentials supplied to the Session Delegation Token binding through `fs.s3a.aws.credentials.provider` are themselves a set of Review Comment: Something is off here, maybe "they themselves are part of session credentials." -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
