[ 
https://issues.apache.org/jira/browse/HADOOP-18320?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17654928#comment-17654928
 ] 

ASF GitHub Bot commented on HADOOP-18320:
-----------------------------------------

ahmarsuhail commented on code in PR #4499:
URL: https://github.com/apache/hadoop/pull/4499#discussion_r1062386144


##########
hadoop-tools/hadoop-aws/src/site/markdown/tools/hadoop-aws/delegation_tokens.md:
##########
@@ -353,10 +352,10 @@ it is authenticated with; the role token binding will 
fail.
 
 When the AWS credentials supplied to the Session Delegation Token binding
 through `fs.s3a.aws.credentials.provider` are themselves a set of

Review Comment:
   this seems fine to me as is. Maybe removing the themselves entirely would 
help, so it becomes "through `fs.s3a.aws.credentials.provider` are a set of", 
but personally feel it's clearer as is.





> Improve S3A delegations token documentation
> -------------------------------------------
>
>                 Key: HADOOP-18320
>                 URL: https://issues.apache.org/jira/browse/HADOOP-18320
>             Project: Hadoop Common
>          Issue Type: Sub-task
>            Reporter: Ahmar Suhail
>            Assignee: Ahmar Suhail
>            Priority: Minor
>              Labels: pull-request-available
>          Time Spent: 20m
>  Remaining Estimate: 0h
>
> The current [delegations token 
> documentation|https://github.com/apache/hadoop/blob/trunk/hadoop-tools/hadoop-aws/src/site/markdown/tools/hadoop-aws/delegation_tokens.md]
>  has some typos, this task tracks fixing those. 



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to