pranavsaxena-microsoft commented on code in PR #5273:
URL: https://github.com/apache/hadoop/pull/5273#discussion_r1063226881
##########
hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/services/ExponentialRetryPolicy.java:
##########
@@ -128,6 +138,8 @@ public boolean shouldRetry(final int retryCount, final int
statusCode) {
return retryCount < this.retryCount
&& (statusCode == -1
|| statusCode == HttpURLConnection.HTTP_CLIENT_TIMEOUT
+ || statusCode == HttpURLConnection.HTTP_GONE
+ || statusCode == HTTP_TOO_MANY_REQUESTS
Review Comment:
Should we keep this in AzureADAuthentication condition.
Reason being, now if any API in AbfsHttpOperation get 429 or 410, it will be
retried 30 times.
Right now what would happen in 429 / 410:
`executeHttpOperation` would give true and in completeExecute after very
first call:
```
if (result.getStatusCode() >= HttpURLConnection.HTTP_BAD_REQUEST) {
throw new AbfsRestOperationException(result.getStatusCode(),
result.getStorageErrorCode(),
result.getStorageErrorMessage(), null, result);
}
```
would throw exception.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
