pranavsaxena-microsoft commented on code in PR #5273:
URL: https://github.com/apache/hadoop/pull/5273#discussion_r1064481413
##########
hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/services/ExponentialRetryPolicy.java:
##########
@@ -128,6 +138,8 @@ public boolean shouldRetry(final int retryCount, final int
statusCode) {
return retryCount < this.retryCount
&& (statusCode == -1
|| statusCode == HttpURLConnection.HTTP_CLIENT_TIMEOUT
+ || statusCode == HttpURLConnection.HTTP_GONE
+ || statusCode == HTTP_TOO_MANY_REQUESTS
Review Comment:
Removing from ExponentialRetryPolicy, we can have
https://github.com/apache/hadoop/pull/5273/files#diff-dff9c93d1668203c206aa1c092aef9d2921dc6e20af8888d06fae34778991531R320-R321
as
```
!succeeded && isRecoverableFailure
&& (tokenFetchRetryPolicy.shouldRetry(retryCount, httperror)||httpError==429
||httpError==410);
```
reason being, this check is only required in ADAuthenticator.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
