virajjasani commented on PR #5315: URL: https://github.com/apache/hadoop/pull/5315#issuecomment-1408995424
> I've reviewed where log4j gets used in the production code. I do worry that today there's enough reflection that if deployed with logback all is good, but now log4j is required. Even without this patch, if we don't have log4j in classpath, hdfs cannot come up right? For instance, `MetricsLoggerTask` is adding appenders dynamically and for that, we do need appender classes to be present in the classpath, meaning log4j is mandatory in the classpath. However, I am going to cover all dynamic async appenders and replace with log4j properties, then we can directly use SLF4J and remove all Log4J references in the codebase. Does this sound good? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
