virajjasani commented on code in PR #5315: URL: https://github.com/apache/hadoop/pull/5315#discussion_r1090918735
########## hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/ReflectionUtils.java: ########## @@ -223,35 +222,6 @@ public synchronized static void printThreadInfo(PrintStream stream, private static long previousLogTime = 0; - /** - * Log the current thread stacks at INFO level. - * @param log the logger that logs the stack trace - * @param title a descriptive title for the call stacks - * @param minInterval the minimum time from the last - */ - public static void logThreadInfo(Log log, Review Comment: Same as above, this can whole work behind log4j2 can only be in 4.0.0 if we follow compatibility guidelines. ########## hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/service/ServiceOperations.java: ########## @@ -67,26 +66,6 @@ public static Exception stopQuietly(Service service) { return stopQuietly(LOG, service); } - /** - * Stop a service; if it is null do nothing. Exceptions are caught and - * logged at warn level. (but not Throwables). This operation is intended to - * be used in cleanup operations - * - * @param log the log to warn at - * @param service a service; may be null - * @return any exception that was caught; null if none was. - * @see ServiceOperations#stopQuietly(Service) - */ - public static Exception stopQuietly(Log log, Service service) { Review Comment: Unfortunately we can't keep this method on trunk branch, because this method directly takes commons logging Log reference :( And since this class is IA.Public, this change can only be taken up in trunk branch only and not on branch-3.3 for now. We can move forward with log4j2 only on 4.0.0 release (something similar to hbase). FYI @Apache9 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org