virajjasani commented on PR #5330:
URL: https://github.com/apache/hadoop/pull/5330#issuecomment-1416207201
In the meantime, I have two nits if you would like to consider:
1. For `processCommandFromActive` and `processCommandFromStandby`, it would
be good to pass only `actor.getNNSocketAddress()` instead of `actor`, because
it's the namenode address that is logged for `BlockRecoveryWorker` logs and
others in standby.
2. Would be great to change log level to WARN for this:
```
if (processCommandsMs > dnConf.getProcessCommandsThresholdMs()) {
LOG.info("Took {} ms to process {} commands from NN",
processCommandsMs, cmds.length);
}
```
With WARN level, it will likely come up front while debugging any slowness
issues.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
