zhangshuyan0 commented on PR #5330: URL: https://github.com/apache/hadoop/pull/5330#issuecomment-1418437375
It is great to prevent the heartbeat from being affected by command processing. I checked that processCommandFromXXX() doesn't access any members inside BPOfferService that can be changed. The only thing to note is that in the original code, after the switchover, the new ANN can guarantee that the DN will not execute the commands from the old ANN as long as it receives two heartbeats from the DN. After the function is placed outside the lock, this guarantee no longer exists. However, as @hfutatzhanghb said, NN will set the DataNode to stale after the switchover, which means that NN does not rely on this guarantee. So, I think this patch is safe. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
