mccormickt12 commented on code in PR #5322:
URL: https://github.com/apache/hadoop/pull/5322#discussion_r1119413264
##########
hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/DFSInputStream.java:
##########
@@ -197,6 +197,15 @@ private void clearLocalDeadNodes() {
deadNodes.clear();
}
+ /**
+ * Clear list of ignored nodes used for hedged reads.
+ */
+ private void clearIgnoredNodes(Collection<DatanodeInfo> ignoredNodes) {
Review Comment:
I could add a `clearSkippedNodes` and then clear both dead and ignored in
there, but that might be confusing as it sounds like theres another node
type/list. I don't think `clearLocalDeadNodes` should also clear ignoredNodes
because thats a bit miselading. The deadnodes and ignore nodes are handled
differently, so i don't think its crazy to keep them separate and clear.
(like i said before) i would add a method that clears both dead and ignore,
but concerned it may be confusing. lmk what you think
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
