mccormickt12 commented on code in PR #5322:
URL: https://github.com/apache/hadoop/pull/5322#discussion_r1119413903
##########
hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/DFSInputStream.java:
##########
@@ -1337,8 +1352,12 @@ private void hedgedFetchBlockByteRange(LocatedBlock
block, long start,
} catch (InterruptedException ie) {
// Ignore and retry
}
- if (refetch) {
- refetchLocations(block, ignored);
+ // If refetch is true, then all nodes are in deadNodes or ignoredNodes.
+ // We should loop through all futures and remove them, so we do not
+ // have concurrent requests to the same node.
+ // Once all futures are cleared, we can clear the ignoredNodes and
retry.
Review Comment:
yes, the thing i am trying to emphasize is the `&& futures.isEmpty()` check
which is specific to how ignored nodes is cleared
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
