saxenapranav commented on code in PR #5450:
URL: https://github.com/apache/hadoop/pull/5450#discussion_r1124561712
##########
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/LowRedundancyBlocks.java:
##########
@@ -369,7 +369,7 @@ synchronized boolean remove(BlockInfo block,
* @return true if the block was found and removed from one of the priority
* queues
*/
- boolean remove(BlockInfo block, int priLevel) {
+ synchronized boolean remove(BlockInfo block, int priLevel) {
Review Comment:
> > should `boolean remove(BlockInfo block, int priLevel, int
oldExpectedReplicas)` be made synchronized instead. Its other callers are
synchronized methods:
>
> Sorry I don't quite understand. Since the callers are already
synchronized, why is it necessary to made `boolean remove(BlockInfo block, int
priLevel, int oldExpectedReplicas)` synchronized?
Since `boolean remove(BlockInfo block, int priLevel)` forwards the call to
`boolean remove(BlockInfo block, int priLevel, int oldExpectedReplicas)`, I am
suggesting that lets make `boolean remove(BlockInfo block, int priLevel, int
oldExpectedReplicas)` synchronized instead.
Callers of `boolean remove(BlockInfo block, int priLevel, int
oldExpectedReplicas)` are synchronized means that we can have `boolean
remove(BlockInfo block, int priLevel, int oldExpectedReplicas)` as synchronized
without any perf-loss.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
