zhangshuyan0 commented on code in PR #5450:
URL: https://github.com/apache/hadoop/pull/5450#discussion_r1125809336
##########
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/LowRedundancyBlocks.java:
##########
@@ -369,7 +369,7 @@ synchronized boolean remove(BlockInfo block,
* @return true if the block was found and removed from one of the priority
* queues
*/
- boolean remove(BlockInfo block, int priLevel) {
+ synchronized boolean remove(BlockInfo block, int priLevel) {
Review Comment:
Thanks for your suggestion, I'll make both `boolean remove(BlockInfo block,
int priLevel, int oldExpectedReplicas)` and `boolean remove(BlockInfo block,
int priLevel)` synchronized to ensure correctness.
However, I think you misunderstood the semantics of `synchronized` a method.
Refer to [java
doc](https://docs.oracle.com/javase/tutorial/essential/concurrency/syncmeth.html):
> When one thread is executing a synchronized method for an object, all
other threads that invoke synchronized methods for the same object block
(suspend execution) until the first thread is done with the object.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
