virajjasani commented on PR #5451: URL: https://github.com/apache/hadoop/pull/5451#issuecomment-1454986793
> TestAuditLog is also doing this File logic in the last PR, should change it to use the same approach there as well. Yeah that's fine too. On the other hand, we can keep things as is too, i.e. one test reads file, another test reads through console appender (as of current state of this PR). The contents read are used by both to compare regex for the particular filesystem operations they both perform. There is no attempt to update the file status (like delete the file) anymore, hence things should be good AFAICT. Thank you @ayushtkn for the review. And sure let's wait for @jojochuang too. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
