virajjasani commented on PR #5451:
URL: https://github.com/apache/hadoop/pull/5451#issuecomment-1455158738

   For that to happen, all tests (the entire test class I mean) should also use 
stop capturing of appender (which internally removes the appender). I just did 
that in recent commit to set an example but it seems not all tests are 
following this. 
   
   While it's not that much of a big deal IMO as tests are supposed to extract 
the specific content that they are interested in but leaving appenders behind 
(without removing them i.e. without doing cleanup) will just keep adding more 
and more logs getting written to more string buffers.
   
   I can do this cleanup for other tests in a separate sub-task if you are 
fine. Please let me know.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to