[ 
https://issues.apache.org/jira/browse/HADOOP-7557?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13218440#comment-13218440
 ] 

Suresh Srinivas commented on HADOOP-7557:
-----------------------------------------

Comments:
# Why use Server.IpcSerializationType in Client.java? There are other 
references to Server as well in the client. This can be cleaned up in a 
separate jira.
# connectionHeader is always null in Server#readAndProcess()
# Some indentation issues in IpcConnectionContext.proto
# Server#respondUnsupportedSerialization is sending VersionMismatch.class as 
error class.

+1 with comments addressed.
                
> Make  IPC  header be extensible
> -------------------------------
>
>                 Key: HADOOP-7557
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7557
>             Project: Hadoop Common
>          Issue Type: Sub-task
>            Reporter: Sanjay Radia
>            Assignee: Sanjay Radia
>         Attachments: HADOOP-7557.patch, IpcHeader.proto, ipcHeader1.patch, 
> ipcHeader2.patch, ipcHeader3.patch, ipcHeader4.patch, ipcHeader5.patch, 
> ipcHeader7.patch, ipcHeader8.patch
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to