steveloughran commented on code in PR #5494:
URL: https://github.com/apache/hadoop/pull/5494#discussion_r1141953901
##########
hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/services/AbfsClient.java:
##########
@@ -519,11 +528,26 @@ public AbfsClientRenameResult renamePath(
final String destination,
final String continuation,
final TracingContext tracingContext,
- final String sourceEtag,
+ String sourceEtag,
boolean isMetadataIncompleteState)
throws AzureBlobFileSystemException {
final List<AbfsHttpHeader> requestHeaders = createDefaultHeaders();
+ // etag passed in, so source is a file
+ final boolean hasEtag = isEmpty(sourceEtag);
+ boolean isDir = !hasEtag;
+ if (!hasEtag && renameResilience) {
Review Comment:
yeah, but AFAIK there's no way to check in the client whether it is
available.
it can only get passed in through the manifest committer, and as
`ABFS.createResilientCommitSupport()` requires etag preservation, it won't be
doing it on a non-HNS store.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
