steveloughran commented on PR #5494:
URL: https://github.com/apache/hadoop/pull/5494#issuecomment-1476907289
so hdfs returns false if source not found, or dest exists
```xml
<property>
<name>fs.contract.rename-returns-false-if-dest-exists</name>
<value>true</value>
</property>
<property>
<name>fs.contract.rename-returns-false-if-source-missing</name>
<value>true</value>
</property>
```
abfs does the same.
s3a client blows up with meaningful errors
```xml
<property>
<name>fs.contract.rename-returns-false-if-source-missing</name>
<value>false</value>
</property>
<property>
<name>fs.contract.rename-returns-false-if-dest-exists</name>
<value>false</value>
</property>
```
I'm more in favour of the "blow up" strategy; if you look at almost all uses
of rename it is code like:
```java
if (!rename(src, dest)) throw new Exception("rename failed we don't know
why")p
```
and nobody ever seems to complain about the s3a failure...but then of course
rename is broken there for other reasons, so maybe code just avoids it (e.g.
committers).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
