[
https://issues.apache.org/jira/browse/HADOOP-18701?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17713928#comment-17713928
]
ASF GitHub Bot commented on HADOOP-18701:
-----------------------------------------
hadoop-yetus commented on PR #5567:
URL: https://github.com/apache/hadoop/pull/5567#issuecomment-1514212026
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|:----:|----------:|--------:|:--------:|:-------:|
| +0 :ok: | reexec | 0m 0s | | Docker mode activated. |
| -1 :x: | docker | 11m 33s | | Docker failed to build run-specific
yetus/hadoop:tp-10388}. |
| Subsystem | Report/Notes |
|----------:|:-------------|
| GITHUB PR | https://github.com/apache/hadoop/pull/5567 |
| Console output |
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5567/2/console |
| versions | git=2.17.1 |
| Powered by | Apache Yetus 0.14.0 https://yetus.apache.org |
This message was automatically generated.
> Generic Build Improvements
> --------------------------
>
> Key: HADOOP-18701
> URL: https://issues.apache.org/jira/browse/HADOOP-18701
> Project: Hadoop Common
> Issue Type: Wish
> Reporter: Ayush Saxena
> Priority: Major
> Labels: pull-request-available
>
> Some proposed build changes.
> * Add {{surefire.failIfNoSpecifiedTests}} as false in POM, else it fails if
> the test specified in -Dtest isn't there in that module, creates problem when
> you plan to run multiple tests across multiple sub-projects from the root of
> the project.
> (https://maven.apache.org/surefire/maven-surefire-plugin/test-mojo.html#failifnospecifiedtests)
> {noformat}
> [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-surefire-plugin:3.0.0:test (default-test) on
> project hadoop-build-tools: No tests matching pattern
> "TestServiceInterruptHandling" were executed! (Set
> -Dsurefire.failIfNoSpecifiedTests=false to ignore this error.)
> {noformat}
> * Disable Concurrent builds: Folks push multiple commits in 5-10 mins while
> pre-commit is running already, so good to discourage this.
> * Add threshold to number of builds per day, saves resources for genuine
> PR's against someone pushing multiple commits. (This & the above one: Copied
> idea from Hive)
> * Leverage Github Actions to delegate some of the tasks to them, so a bit of
> parallel execution and might save time, may be explore pushing JDK-11 related
> stuff to Github Actions (We don't run tests as of now for both JDK-11 & 8,
> tests are for 8 only in precommit)
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
