simbadzina commented on code in PR #5691:
URL: https://github.com/apache/hadoop/pull/5691#discussion_r1208078130
##########
hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/router/NamenodeHeartbeatService.java:
##########
@@ -447,8 +462,13 @@ private void updateJMXParameters(
String address, NamenodeStatusReport report) {
try {
// TODO part of this should be moved to its own utility
- getFsNamesystemMetrics(address, report);
- getNamenodeInfoMetrics(address, report);
+ if (shouldUpdateJmx()) {
+ lastJmxUpdateAttempt = Time.monotonicNow();
+ getFsNamesystemMetrics(address);
+ getNamenodeInfoMetrics(address);
+ }
+ populateFsNamesystemMetrics(fsNamesystemMetrics, report);
+ populateNamenodeInfoMetrics(namenodeInfoMetrics, report);
Review Comment:
My other question was "How does the AvailableSpaceResolver and related code
behave when we fully disable updating JMX parameters?". In this case the
reported value will be 0.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
