hchaverri commented on code in PR #5691:
URL: https://github.com/apache/hadoop/pull/5691#discussion_r1207175135
##########
hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/router/NamenodeHeartbeatService.java:
##########
@@ -107,6 +110,15 @@ public class NamenodeHeartbeatService extends
PeriodicService {
/** URL scheme to use for JMX calls. */
private String scheme;
+ /** Frequency of updates to JMX report. */
+ private long updateJmxIntervalMs;
+ /** Timestamp of last attempt to update JMX report. */
+ private long lastJmxUpdateAttempt;
Review Comment:
These metrics are being used but not in a critical path for all cases (see
[RBFMetrics](https://github.com/apache/hadoop/blob/trunk/hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/metrics/RBFMetrics.java)
or
[AvailableSpaceResolver](https://github.com/apache/hadoop/blob/trunk/hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/resolver/order/AvailableSpaceResolver.java)
for examples). This PR only gives the option to change the frequency to reduce
impact on the Namenode
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
