[ 
https://issues.apache.org/jira/browse/HADOOP-18748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17730091#comment-17730091
 ] 

ASF GitHub Bot commented on HADOOP-18748:
-----------------------------------------

alkis commented on PR #5685:
URL: https://github.com/apache/hadoop/pull/5685#issuecomment-1580679069

   > 1. everything broke. As I warned, Configuration is sensitive piece of code.
   
   I am not sure the breakages are related. The error message is:
   ```
   Unable to parse configuration fs.permissions.umask-mode with value 
dfs.umaskmode as octal or symbolic umask.
   ```
   and this change does not have any effect on parsing.
   
   Do the tests work at HEAD? How can I trigger them?
   
   > 2. can you not rebase and force push unless you absolutely have to, as it 
complicates reviewing. thanks.
   
   Sure. I will merge instead if that's more convenient.




> Configuration.get is slow
> -------------------------
>
>                 Key: HADOOP-18748
>                 URL: https://issues.apache.org/jira/browse/HADOOP-18748
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: conf
>    Affects Versions: 3.3.5
>            Reporter: Alkis Evlogimenos
>            Priority: Major
>              Labels: pull-request-available
>
> `Configuration.get` is slow mainly because of the overhead of 
> `handleDeprecation` and eager creation of `overlay` even when null.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to