[
https://issues.apache.org/jira/browse/HADOOP-18748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17730442#comment-17730442
]
ASF GitHub Bot commented on HADOOP-18748:
-----------------------------------------
alkis commented on PR #5685:
URL: https://github.com/apache/hadoop/pull/5685#issuecomment-1582106658
> ok, style failures
>
> ```
>
./hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/conf/Configuration.java:754:
Properties overlay = getOverlay();:16: 'overlay' hides a field.
[HiddenField]
>
./hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/conf/ConfigurationBenchmark.java:1:package
org.apache.hadoop.conf;public class ConfigurationBenchmark {:31: ';' is not
followed by whitespace. [WhitespaceAfter]
> ```
>
> the overlay one needs new variable name.
>
> the ConfigurationBenchmark one looks like one of the PRs added a file,
which somehow is still around for the style checking.
>
> Probably the strategy there is actually do a squash commit and forced
write, so we are down to a single patch. I know, it's not "elegant" but it
ensures that there's no memory of a transient file
Fixed the style failures and rewrote the history to sidestep the accidental
addition of the file.
> Configuration.get is slow
> -------------------------
>
> Key: HADOOP-18748
> URL: https://issues.apache.org/jira/browse/HADOOP-18748
> Project: Hadoop Common
> Issue Type: Improvement
> Components: conf
> Affects Versions: 3.3.5
> Reporter: Alkis Evlogimenos
> Priority: Major
> Labels: pull-request-available
>
> `Configuration.get` is slow mainly because of the overhead of
> `handleDeprecation` and eager creation of `overlay` even when null.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
