steveloughran commented on PR #5780: URL: https://github.com/apache/hadoop/pull/5780#issuecomment-1611994029
@saxenapranav having the close() in finalize helps avoid leakage of threads and things if caching for an fs schema is disabled and clients call FileSystem.get(path), the way they should: normally apps shouldn't close it. In #4966 we had to add finalizers to the FileContext bindings as they were leaking. One thing to consider is this problem surfaced as reports of the output stream hanging in close(): it was waiting for the async uploads to finish but because all was broken, that was not to be. Mukund, as well as avoiding premature close(), can this PR have output stream close() fail noisily if the thread pool was shut down? this is at least testable, to an extent -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
