mehakmeet commented on PR #5780: URL: https://github.com/apache/hadoop/pull/5780#issuecomment-1617203652
> No similar test for InputStream? So, InputStream doesn't actually use any threadpool passed from the FS instance so would be tricky to test that. But, Let me just add a test for checking back reference notNull, that should be enough I think. > Can we also handle filesystem.close() in the output stream by failing cleanly if the fs was explicitly closed()? @steveloughran Was thinking about this, so essentially whenever an Abfs.close() is closed we need to call the stream's close() as well, so that we can flush any remaining writes etc? Was thinking how this should be handled say mid way through a write, currently, I believe since the executor itself is shut down it just simply rejects any request incoming like this ``` Could not submit task to executor java.util.concurrent.ThreadPoolExecutor@5c5e7584[Terminated, pool size = 0, active threads = 0, queued tasks = 0, completed tasks = 0] ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
