Hexiaoqiao commented on code in PR #5759:
URL: https://github.com/apache/hadoop/pull/5759#discussion_r1247427463
##########
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/BlockPlacementPolicyRackFaultTolerant.java:
##########
@@ -192,11 +192,23 @@ private void chooseEvenlyFromRemainingRacks(Node writer,
} finally {
excludedNodes.addAll(newExcludeNodes);
}
+ if (numResultsOflastChoose == results.size()) {
Review Comment:
It will be better to add some annotation here.
##########
hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestReconstructStripedBlocks.java:
##########
@@ -515,4 +517,63 @@ public void testReconstrutionWithBusyBlock1() throws
Exception {
assertEquals(9, bm.countNodes(blockInfo).liveReplicas());
}
+ @Test
+ public void testReconstructionWithStorageTypeNotEnough() throws Exception {
+ final HdfsConfiguration conf = new HdfsConfiguration();
+ conf.setInt(DFSConfigKeys.DFS_NAMENODE_REDUNDANCY_INTERVAL_SECONDS_KEY, 1);
+
+ // nine disk node eleven archive node
Review Comment:
Please use a capital letter at the beginning of the sentences and period at
the end of annotation. (L525,L533,L556,L563)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
