whbing commented on code in PR #5759:
URL: https://github.com/apache/hadoop/pull/5759#discussion_r1247501492
##########
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/BlockPlacementPolicyRackFaultTolerant.java:
##########
@@ -192,11 +192,23 @@ private void chooseEvenlyFromRemainingRacks(Node writer,
} finally {
excludedNodes.addAll(newExcludeNodes);
}
+ if (numResultsOflastChoose == results.size()) {
+ Map<String, Integer> nodesPerRack = new HashMap<>();
+ for (DatanodeStorageInfo dsInfo : results) {
+ String rackName =
dsInfo.getDatanodeDescriptor().getNetworkLocation();
+ nodesPerRack.merge(rackName, 1, Integer::sum);
+ }
+ for (int numNodes : nodesPerRack.values()) {
+ if (numNodes > bestEffortMaxNodesPerRack) {
+ bestEffortMaxNodesPerRack = numNodes;
+ }
Review Comment:
Line 201~203 get max value, maybe we can use the following code to make it
more clear and concise.
```java
bestEffortMaxNodesPerRack =
Math.max(bestEffortMaxNodesPerRack,
Collections.max(nodesPerRack.values()));
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
