brumi1024 commented on code in PR #5792:
URL: https://github.com/apache/hadoop/pull/5792#discussion_r1252989818
##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/fair/allocation/AllocationFileQueueParser.java:
##########
@@ -211,6 +211,9 @@ private void loadQueue(String parentName, Element element,
isReservable = true;
builder.reservableQueues(queueName);
builder.configuredQueues(FSQueueType.PARENT, queueName);
+ LOG.warn("During fs2cs conversion, we cannot convert the leaf queue "
+ + queueName + " to weight mode without losing the " +
+ "reservation functionality.");
Review Comment:
Can you please change this log to appear only when the weight mode is set as
the target queue mode? Using --percentage or -pc flag when launching fs2cs will
result in a percentage config, where this log is misleading.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
