brumi1024 commented on code in PR #5792:
URL: https://github.com/apache/hadoop/pull/5792#discussion_r1258475720
##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/fair/converter/TestFSQueueConverter.java:
##########
@@ -351,13 +351,16 @@ public void testAutoCreateV2FlagsInWeightMode() {
csConfig.getBoolean(
PREFIX + "root.misc.auto-queue-creation-v2.enabled", false));
+ //leaf queue root.admins.alice is removed from the below list
+ //adding reservation to a leaf, it's queueType changes to FSParentQueue
Set<String> leafs = Sets.difference(ALL_QUEUES,
Sets.newHashSet("root",
"root.default",
"root.admins",
"root.users",
- "root.misc"));
- assertNoValueForQueues(leafs, "auto-queue-creation-v2.enabled",
+ "root.misc",
+ "root.admins.alice"));
Review Comment:
Nit: please add root.admins.alice to the assertTrue part as well, as
essentially it's expected to have the flag.
##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/fair/converter/TestFSQueueConverter.java:
##########
@@ -351,13 +351,16 @@ public void testAutoCreateV2FlagsInWeightMode() {
csConfig.getBoolean(
PREFIX + "root.misc.auto-queue-creation-v2.enabled", false));
+ //leaf queue root.admins.alice is removed from the below list
+ //adding reservation to a leaf, it's queueType changes to FSParentQueue
Set<String> leafs = Sets.difference(ALL_QUEUES,
Sets.newHashSet("root",
"root.default",
Review Comment:
"root.default" is misleading here, it should not have the
auto-queue-creation-v2.enabled flag, however because of the Sets.difference
call it's removed from this validation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
