xinglin commented on code in PR #5803:
URL: https://github.com/apache/hadoop/pull/5803#discussion_r1259001493


##########
hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/server/namenode/ha/ObserverReadProxyProvider.java:
##########
@@ -648,6 +645,7 @@ public synchronized void close() throws IOException {
       }
     }
     failoverProxy.close();
+    nnProbingThreadPool.shutdown();

Review Comment:
   The expected behavior is we will wait for the main thread to exit and the 
threads in the executorService pool to shut down (after idle for 10 seconds). 
Then, the JVM process will be shut down. In the worst case, we may take 10 more 
seconds to shut down the JVM process. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to