[
https://issues.apache.org/jira/browse/HADOOP-18816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17744997#comment-17744997
]
ASF GitHub Bot commented on HADOOP-18816:
-----------------------------------------
steveloughran commented on code in PR #5863:
URL: https://github.com/apache/hadoop/pull/5863#discussion_r1269222686
##########
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/RemoteException.java:
##########
@@ -47,12 +50,23 @@ public RemoteException(String className, String msg) {
* @param erCode may be null
*/
public RemoteException(String className, String msg, RpcErrorCodeProto
erCode) {
+ this(className, msg, erCode, null);
+ }
+
+ /**
+ * @param className wrapped exception, may be null
Review Comment:
nit: add a . here and in other javadocs, to keep the compilers happy
##########
hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestProtoBufRpc.java:
##########
@@ -329,7 +331,30 @@ public void testProtoBufRandomException() throws Exception
{
.isEqualTo(RpcErrorCodeProto.ERROR_APPLICATION);
}
}
-
+
+ @Test (timeout=5000)
+ public void testProtoBufReconstructableException() throws Exception {
+ //No test with legacy
+ assumeFalse(testWithLegacy);
+ TestRpcService client = getClient(addr, conf);
+
+ try {
+ client.error3(null, newEmptyRequest());
+ } catch (ServiceException se) {
+ assertThat(se.getCause()).isInstanceOf(RemoteException.class);
Review Comment:
if you use the AssertJ assertThat() (which a lot of new code does) you can
explictily use an .isInstanceOf() assert and get more detail on the error
##########
hadoop-common-project/hadoop-common/src/main/proto/RpcHeader.proto:
##########
@@ -165,6 +165,7 @@ message RpcResponseHeaderProto {
// The client should not interpret these bytes, but only
// forward them to the router using
RpcRequestHeaderProto.routerFederatedState.
optional bytes routerFederatedState = 10;
+ optional ExceptionReconstructParamsProto exceptionReconstructParams = 11;
Review Comment:
add a comment above to ensure no confusion with the comment at L165
##########
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/protocolPB/PBHelper.java:
##########
@@ -134,4 +136,14 @@ public static FileStatusProto convert(FileStatus stat)
throws IOException {
return bld.build();
}
+ public static ExceptionReconstructParamsProto getReconstructParams(Throwable
t) {
+ if (t instanceof ReconstructableException) {
Review Comment:
and instance of IOException?
##########
hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestReconstructableException.java:
##########
@@ -0,0 +1,59 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hadoop.ipc;
+
+import java.io.IOException;
+
+/**
+ * Test class of ReconstructableException.
+ */
+public class TestReconstructableException extends IOException
Review Comment:
as all unit tests begin with Test, I'd prefer a different classname to aviod
confusion
##########
hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestReconstructableException.java:
##########
@@ -0,0 +1,59 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hadoop.ipc;
+
+import java.io.IOException;
+
+/**
+ * Test class of ReconstructableException.
+ */
+public class TestReconstructableException extends IOException
+ implements ReconstructableException<TestReconstructableException> {
+
+ private String field1;
+ private String field2;
Review Comment:
make one final, to see what happens
##########
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/RemoteException.java:
##########
@@ -47,12 +50,23 @@ public RemoteException(String className, String msg) {
* @param erCode may be null
*/
public RemoteException(String className, String msg, RpcErrorCodeProto
erCode) {
+ this(className, msg, erCode, null);
+ }
+
+ /**
+ * @param className wrapped exception, may be null
+ * @param msg may be null
+ * @param erCode may be null
+ */
+ public RemoteException(String className, String msg, RpcErrorCodeProto
erCode,
+ ExceptionReconstructParamsProto paramsProto) {
super(msg);
this.className = className;
if (erCode != null)
Review Comment:
good time to add {} here, or move to ? : instead. I know its old code, but
it is adjacent to your work
> Rebuild Exceptions on Client side to get genuine exceptions
> -----------------------------------------------------------
>
> Key: HADOOP-18816
> URL: https://issues.apache.org/jira/browse/HADOOP-18816
> Project: Hadoop Common
> Issue Type: Task
> Reporter: Janus Chow
> Assignee: Janus Chow
> Priority: Major
> Labels: pull-request-available
>
> In current's RPC design, if Server sends an exception back, Client can only
> rebuild the exception according to the original exception's error message, if
> the exceptions has some fields containing important information, they will be
> discarded since we can not rebuild them based on message string easily.
> This ticket is to introduce a new interface for Exceptions which supports
> reconstructing. If Clients want to rebuild the exception, they can just
> implement the methods and the reconstruction will be done automatically.
> The interface uses String[] as parameter for simplicity. I thought of using
> Protobuf to store all the exceptions or fields, but the generacity can not be
> perfectlly met. So we need Client to support it by accepting "String[]" and
> transform the String to it's original type.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
