[
https://issues.apache.org/jira/browse/HADOOP-18816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17745001#comment-17745001
]
ASF GitHub Bot commented on HADOOP-18816:
-----------------------------------------
symious commented on code in PR #5863:
URL: https://github.com/apache/hadoop/pull/5863#discussion_r1269244864
##########
hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestProtoBufRpc.java:
##########
@@ -329,7 +331,30 @@ public void testProtoBufRandomException() throws Exception
{
.isEqualTo(RpcErrorCodeProto.ERROR_APPLICATION);
}
}
-
+
+ @Test (timeout=5000)
+ public void testProtoBufReconstructableException() throws Exception {
+ //No test with legacy
+ assumeFalse(testWithLegacy);
+ TestRpcService client = getClient(addr, conf);
+
+ try {
+ client.error3(null, newEmptyRequest());
+ } catch (ServiceException se) {
+ assertThat(se.getCause()).isInstanceOf(RemoteException.class);
Review Comment:
Updated the following assert, please have a look.
> Rebuild Exceptions on Client side to get genuine exceptions
> -----------------------------------------------------------
>
> Key: HADOOP-18816
> URL: https://issues.apache.org/jira/browse/HADOOP-18816
> Project: Hadoop Common
> Issue Type: Task
> Reporter: Janus Chow
> Assignee: Janus Chow
> Priority: Major
> Labels: pull-request-available
>
> In current's RPC design, if Server sends an exception back, Client can only
> rebuild the exception according to the original exception's error message, if
> the exceptions has some fields containing important information, they will be
> discarded since we can not rebuild them based on message string easily.
> This ticket is to introduce a new interface for Exceptions which supports
> reconstructing. If Clients want to rebuild the exception, they can just
> implement the methods and the reconstruction will be done automatically.
> The interface uses String[] as parameter for simplicity. I thought of using
> Protobuf to store all the exceptions or fields, but the generacity can not be
> perfectlly met. So we need Client to support it by accepting "String[]" and
> transform the String to it's original type.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
