simbadzina commented on code in PR #5860:
URL: https://github.com/apache/hadoop/pull/5860#discussion_r1272444972
##########
hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/router/RouterClientProtocol.java:
##########
@@ -1928,9 +1928,14 @@ public BatchedEntries<OpenFileEntry> listOpenFiles(long
prevId,
@Override
public void msync() throws IOException {
rpcServer.checkOperation(NameNode.OperationCategory.READ, true);
- Set<FederationNamespaceInfo> nss = namenodeResolver.getNamespaces();
+ // Only msync to nameservices with observer reads enabled.
+ Set<FederationNamespaceInfo> allNamespaces =
namenodeResolver.getNamespaces();
RemoteMethod method = new RemoteMethod("msync");
- rpcClient.invokeConcurrent(nss, method);
+ Set<FederationNamespaceInfo> namespacesEligibleForObserverReads =
allNamespaces
+ .stream()
+ .filter(ns ->
rpcClient.isNamespaceObserverReadEligible(ns.getNameserviceId()))
+ .collect(Collectors.toSet());
+ rpcClient.invokeConcurrent(namespacesEligibleForObserverReads, method);
Review Comment:
You are right. I added a new test case that was failing with the following
error
```
org.apache.hadoop.ipc.RemoteException(java.io.IOException): No remote
locations available
at
org.apache.hadoop.hdfs.server.federation.router.RouterRpcClient.invokeConcurrent(RouterRpcClient.java:1460)
at
org.apache.hadoop.hdfs.server.federation.router.RouterRpcClient.invokeConcurrent(RouterRpcClient.java:1395)
at
org.apache.hadoop.hdfs.server.federation.router.RouterRpcClient.invokeConcurrent(RouterRpcClient.java:1366)
```
I've implemented your suggested fix. Thanks for catching this @ayushtkn
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
