xinglin commented on code in PR #5860:
URL: https://github.com/apache/hadoop/pull/5860#discussion_r1272550379
##########
hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/router/RouterClientProtocol.java:
##########
@@ -264,7 +264,7 @@ public HdfsFileStatus create(String src, FsPermission
masked,
String clientName, EnumSetWritable<CreateFlag> flag,
boolean createParent, short replication, long blockSize,
CryptoProtocolVersion[] supportedVersions, String ecPolicyName,
- String storagePolicy)
+ String storagePolicyName)
Review Comment:
I don't have context regarding how this practice came into play. In my
opinion, we should be open to include such trivial improvements.
- It is clear from retrospective that this is a trivial rename improvement.
There is no confusion that such a trivial change would cause.
Otherwise, we would have to create a separate PR to get this trivial change
in, which would
- Add more work to the PR author
- Add more review load.
Even worse, given such a trivial improvement, people may simply don't want
to do it, as a separate PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
