steveloughran commented on PR #5982: URL: https://github.com/apache/hadoop/pull/5982#issuecomment-1693298196
1. afraid you need to create a jira at issues.apache.org for this, if you need to create an account say you have a pending github pr 2. We use our LambdaTestUtils.intercept() here as it is better. really. in particular, if nothing was thrown, the assertion raised includes the toString() value of whatever was returned from the lambda-expression; really helps interpreting test failures. you might want to look at LambdaTestUtils, compare it to ScalaTest and see how it is being extended to handle futures and the like. outside that, we are moving towards AssertJ as our assertion language because it is better *and* extensible (see IOStatisticAssertions) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
