steveloughran commented on PR #5982: URL: https://github.com/apache/hadoop/pull/5982#issuecomment-1710548213
ok. now, one thing to consider there is: what stylecheckers etc can we use to stop new prs coming in which don't do all of this, or lose stack traces when validating caught exceptions? As all to often, the work of getting a PR in is the time spent teaching people how to write tests that meet my expectations (for me) and the time spent waiting for review, making the changes and repeating (for them). see #6003 as an example. if we have the CI tooling automatically imposing policies on tests, then everyone's time is better used. now, we do run checkstyle on all PRs, so if you have suggestions about how to do it there, or other maven plugins (better yet, prs with tests) then I'd be very happy. put differently: lets automate enforcing test quality on new submissions before worrying about old tests which *appear to work ok* -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
